Skip to content

Conversation

y21
Copy link
Member

@y21 y21 commented Sep 30, 2023

Closes #9736 (part 2)

This implements the other lint that my earlier PR missed: given an IntoIterator for &Type impl, check that there exists an inherent fn iter(&self) method.

changelog: new lint: into_iter_without_iter

r? @Jarcho since you reviewed #11527 I figured it makes sense for you to review this as well?

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2023
@y21 y21 force-pushed the into_iter_without_iter branch 2 times, most recently from 7cf95be to d1bb843 Compare September 30, 2023 01:24
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor nits this time.

@y21 y21 force-pushed the into_iter_without_iter branch from d1bb843 to 8eb586d Compare September 30, 2023 17:39
@Jarcho
Copy link
Contributor

Jarcho commented Sep 30, 2023

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2023

📌 Commit 8eb586d has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 30, 2023

⌛ Testing commit 8eb586d with merge 0e43a04...

@bors
Copy link
Contributor

bors commented Sep 30, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 0e43a04 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest implementing IntoIterator for &'_ T where T has iter() method returning an iterator (or vice versa)
4 participants